Skip to content

Conversation

@kevinzwang
Copy link
Contributor

@kevinzwang kevinzwang commented Sep 3, 2025

Daft now has native integration for reading and writing Hugging Face datasets, which we have documented in our docs pages! This PR adds the corresponding docs to the Hugging Face docs.

This PR relies on the daft_hf.png file being uploaded to the huggingface/documentation-images repo, which I have made a PR for here. The image:
daft_hf

Copy link
Member

@davanstrien davanstrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I think it could be worth making the distinction between pushing to the Hub vs writing to a dataset.Dataset a little bit more explicit but this is looking very nice otherwise 🤗

@lhoestq
Copy link
Member

lhoestq commented Sep 4, 2025

awesome ! it would also be cool to showcase how to load/push multimodal data

@kevinzwang
Copy link
Contributor Author

awesome ! it would also be cool to showcase how to load/push multimodal data

@lhoestq thanks for the feedback! I'm not yet happy about Daft's story around the Hugging Face Dataset multimodal types (images, video, audio) and they are currently just represented as some nested binary type in Daft. I plan on building better integrations for them soon, and once we have that I'd love to update these docs with more info if that works.

@lhoestq
Copy link
Member

lhoestq commented Sep 5, 2025

sounds good, looking forward for the multimodal integration :) feel free to ping me if you have questions on the structure or if I can help

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kevinzwang
Copy link
Contributor Author

kevinzwang commented Sep 5, 2025

@davanstrien this (and the documentation images PR) is ready to merge on my end. I don't have the permissions for it, so feel free to do so!

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase or fix the conflicts so the PR only shows the pertinent changes @kevinzwang? 🙏

@kevinzwang
Copy link
Contributor Author

Could you please rebase or fix the conflicts so the PR only shows the pertinent changes @kevinzwang? 🙏

@pcuenca done!

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me whenever @davanstrien is happy with it.

@davanstrien davanstrien merged commit a7bc6b4 into huggingface:main Sep 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants